I came across a couple of bugs today in the Thunderbird code that need a fix, and they are both easy fixes for a student looking for contribution. Basically, in DXR I have a C++ parser to create HTML files with markup versions of source code. My parser chokes on 2 files, because someone did a bad thing and put an extra 0×0c (e.g., \f, form-feed) char in there. This causes all sorts of bad things to happen with tools that try and work on the source and expect things like \n or \r\n or whatever.
[dave@scotland dxr]$ find ./mozilla-trees -name '*.h' -o -name '*.cpp' | xargs grep -n '^L'
./mozilla-trees/comm-central/mailnews/mime/src/mimeenc.cpp:852:
./mozilla-trees/comm-central/mailnews/mime/src/mimei.h:414:
NOTE: to get that ^L you have to type: CTRL+V CTRL+L. This will take you about 1 minute plus the time to build Thunderbird, file a bug, and submit the patch. Interested? If so, leave a comment here or talk to me on irc/email.
4 Comments
If you used ack, you could just type “ack ^L”, and it would do the recursive search for you (and find another occurrence in directory/c-sdk/ldap/libraries/libldap/tmplout.c, which we may or may not want to change).
Later,
Blake.
Here’s the bug with the patch: https://bugzilla.mozilla.org/show_bug.cgi?id=527235
I hope I filed it in the right place
can i work on it in december?
@anirvana: sorry, it’s already done, see bug 527235.